Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sinceDate and untilDate to be configured in config files #634

Closed
yong24s opened this issue Mar 28, 2019 · 11 comments
Closed

Allow sinceDate and untilDate to be configured in config files #634

yong24s opened this issue Mar 28, 2019 · 11 comments
Labels
a-Config p.Low

Comments

@yong24s
Copy link
Contributor

yong24s commented Mar 28, 2019

No description provided.

@damithc damithc changed the title Allow sinceDate and untilDate to be configured in CSV/Standalone configs Allow sinceDate and untilDate to be configured in config files May 16, 2019
@damithc
Copy link
Collaborator

damithc commented May 16, 2019

It's a bit awkward to specify key-value pairs in a csv file though. Might have to add another json file for this purpose.

@damithc damithc added the p.Low label May 16, 2019
@anubh-v
Copy link
Contributor

anubh-v commented Oct 26, 2019

This would allow users to easily compare git activity for repositories that were active over different time periods.

i.e. Repository A was actively developed 1 year ago, while Repository B has only been under development for the past month.

With regards to specifying the sinceDate / untilDate in the repo-config.csv file, I think we could simply add a "Data range" column to repo-config.csv, as shown below?

Repository's Location Branch File formats Ignore Glob List Ignore standalone config Ignore Commits List Date range
https://github.com/foo/bar.git master override:java;css test/** yes 10/10/2018;10/12/2018

@damithc , I'm not clear what you meant by the "difficulty of specifying key-value pairs in a csv".

Does the above proposal for the repo-config.csv seem suitable?

@damithc
Copy link
Collaborator

damithc commented Oct 26, 2019

If the value can differ across different repos, a csv file is the way to go.
But I'm not sure we can handle different periods for different repos. The current ReposSense ramp chart assumes a single timeline.

@anubh-v
Copy link
Contributor

anubh-v commented Oct 27, 2019 •
edited
Loading

Thanks for the response @damithc
Yes, I overlooked that sinceDate and untilDate are report-level parameters, and not repository/branch level.

Perhaps these parameters can be configured in the ReportConfiguration that is being considered in PR #627.

@dcshzj dcshzj mentioned this issue Jan 25, 2021
Open
4 tasks
@dcshzj dcshzj self-assigned this Mar 23, 2021
@dcshzj dcshzj mentioned this issue Mar 23, 2021
Closed
2 tasks
This was referenced Apr 10, 2021
Merged
Merged
fzdy1914 pushed a commit that referenced this issue Apr 20, 2021
@dcshzj
[#634] Extract time-based functionalities to TimeUtil (#1535)
0b38105 
Many of the time-based functionality and logic are scattered about 
in various files, which increases code duplication and is a 
maintenance burden.

Let's abstract all time-based functionalities into the `TimeUtil`
class such that multiple places in the code can reuse the same
logic.
fzdy1914 pushed a commit that referenced this issue Apr 23, 2021
@dcshzj
[#634] Move logic for getting ReportConfiguration to ArgsParser (#1534)
2f4703e 
The design of getting the `ReportConfiguration` object in the main 
RepoSense class is flawed and not so ideal, as it meant that 
configuration has to be set and parsed twice.

Let's move the logic for getting the ReportConfiguration object
into ArgsParser to avoid having to duplicate configuration parsing
in the future.
@FH-30
Copy link
Contributor

FH-30 commented Jul 14, 2021

Hi, can I try working on this issue?

@damithc
Copy link
Collaborator

damithc commented Jul 15, 2021

Hi, can I try working on this issue?

Go ahead @FH-30

@dcshzj
Copy link
Member

dcshzj commented Jul 15, 2021

Sorry @FH-30 @damithc I am currently working on this in #1501. This issue is currently assigned to myself.

@dcshzj
Copy link
Member

dcshzj commented Jul 28, 2021 •
edited
Loading

@FH-30 I have closed my PR as it is not progressing. Feel free to work on this issue if you wish.

@dcshzj dcshzj removed their assignment Jul 28, 2021
@FH-30
Copy link
Contributor

FH-30 commented Jul 28, 2021

Thanks for notifying @dcshzj , I would like to work on this issue!

@dcshzj
Copy link
Member

dcshzj commented Jul 28, 2021

@FH-30 Please do so. You may refer to the original PR I have created if you wish to.

@yhtMinceraft1010X yhtMinceraft1010X mentioned this issue Feb 16, 2022
Merged
@yhtMinceraft1010X
Copy link
Contributor

I propose closing this issue since it has been encapsulated in #1360

@sikai00 sikai00 mentioned this issue Feb 23, 2023
Closed
@ckcherry23 ckcherry23 reopened this Mar 9, 2024
@ckcherry23 ckcherry23 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-Config p.Low
Projects
RepoSense Roadmap
Status: Closed/Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#634] Support defining sinceDate, untilDate and period in report config dcshzj/RepoSense
7 participants
@damithc @yong24s @dcshzj @anubh-v @FH-30 @ckcherry23 @yhtMinceraft1010X