Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model: Add ReportConfiguration #627

Closed
wants to merge 5 commits into from
Closed

Model: Add ReportConfiguration #627

wants to merge 5 commits into from

Conversation

fzdy1914
Copy link
Member

Related #590, #467

Our user cannot edit the property of generated report.

Let's add a new model, ReportConfiguration, which serves the role to
configure the generated report.

@fzdy1914
Copy link
Member Author

@eugenepeh @yamidark
As this is a totally new component, so I would like to ask for your opinion on the implementation of this pr.

For my implementation, I suppose that the report-config.json should under the same folder with the other two configs, which means, this feature only works with ConfigCliArgument.

There is also another possible implementation. We add one more arg e.g. --report-config to specify the location of the folder and put all the file related to the report config in it.

@eugenepeh
Copy link
Member

For my implementation, I suppose that the report-config.json should under the same folder with the other two configs, which means, this feature only works with ConfigCliArgument.

I think we can go with that for now. --repo is usually meant for few repositories, so its not that important to add support for it yet.

@fzdy1914
Copy link
Member Author

Put this PR on hold as there is no time to finish it.

@fzdy1914
Copy link
Member Author

fzdy1914 commented Dec 8, 2019

Anyone who is willing to take over the PR can just go ahead.

@fzdy1914
Copy link
Member Author

Closing this PR because it has been inactive for a very long time. For the contributors who are willing to take over, you may just use the code here as a start point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants