Capture ExecutionContext after every binding invoke #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120
Reqnroll (and Specflow v4,x) uses Async internally (only one code path).
To ensure the user sees no difference between the old (synchronous) implementation and the new ones the
ExecutionContext
(includingAsyncLocal
) are handled manually by Reqnroll.This is done using
ExecutionContext.Capture()
inBindingDelegateInvoker,InvokeInExecutionContext
.The problem is that this only works once.
Background:
ExecutionContextHolder.Value
is null.ExecutionContext.Run
is not called.ExecutionContext
and modifies theAsyncLocal
.ExecutionContext
is capturedExecutionContextHolder.Value
is not null.ExecutionContext.Run
is called.ExecutionContext.Run
captures the currentExecutionContext
ExecutionContext.Run
the Binding-Method is called and modifies theAsyncLocal
.ExecutionContext.Run
restores the captured "old current"ExecutionContext
with the old valuesExecutionContext
is capturedBufix: Capture
ExecutionContext
explicitly inExecutionContext.Run
after every binding invoke.Types of changes
Checklist: