Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleshing out Generation System Tests (2) #99

Merged
merged 16 commits into from
Apr 17, 2024
Merged

Conversation

gasparnagy
Copy link
Contributor

Move over #87 to the a main repo branch

* origin/main:
  Fix for 81 - Cucumber Expression using Enums errors when two enums exist with the same short name (#100)
… version of Reqnroll is subscribed to assembly unload)
@gasparnagy gasparnagy marked this pull request as ready for review April 16, 2024 16:31
@gasparnagy
Copy link
Contributor Author

@clrudolphi Do you want to take a look at this PR (especially the tests)? Maybe you spot out something that should be fixed before merge.

@clrudolphi
Copy link
Contributor

Sure. I'll look at it this afternoon.

@clrudolphi
Copy link
Contributor

@gasparnagy Looks good! I see nothing needing adjustment. (passing on my machine); code cleanups look good with clear intent.

@gasparnagy gasparnagy merged commit 77bea54 into main Apr 17, 2024
9 checks passed
@gasparnagy gasparnagy deleted the system-test-additions branch April 17, 2024 05:34
gasparnagy added a commit that referenced this pull request May 22, 2024
…ons-dependencyinjection-plugin

* origin/main: (21 commits)
  Fix #56 autofac ambiguous stepdef and hook required #127 issue (#139)
  Reduce target framework of Reqnroll to netstandard2.0 (#130)
  Fix StackOverflowException when using [StepArgumentTransformation] with same input and output type (#136)
  MsTest: Replace DelayedFixtureTearDown special case with ClassCleanupBehavior.EndOfClass (#128)
  Temporarily disabled tests until #132 is resolved
  Add NUnit & xUnit core tests to portability suite
  Capture ExecutionContext after every binding invoke (#126)
  small improvement in CodeDomHelper to be able to chain async calls
  fix method name sources in UnitTestFeatureGenerator
  External data plugin, support for JSON files  (#118)
  UnitTests: Check if SDK version is installed and if not ignore the test (#109)
  Fix 111 ignore attr not inherited from rule (#113)
  Update README.md (#110)
  Fix 81 - modified CucumberExpressionParameterTypeRegistry to handle multiple custom types used as cucumber expressions when those types share the same short name. (#104)
  Update index.md
  Simplify test project targets (#105)
  Make SystemTests temp folder configurable and use NUGET_PACKAGES env var to override global NuGet folder
  Fleshing out Generation System Tests (2) (#99)
  Fix for 81 - Cucumber Expression using Enums errors when two enums exist with the same short name (#100)
  Include BoDi to Reqnroll package (#91) (#95)
  ...

# Conflicts:
#	Reqnroll.sln
#	Tests/Reqnroll.PluginTests/Reqnroll.PluginTests.csproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants