Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleshing out Generation System Tests #87

Closed
wants to merge 5 commits into from

Conversation

clrudolphi
Copy link
Contributor

First commit to flesh out the Generation System Test suite. Per TODO comments in the code, added test methods to confirm system test integration of Failing, Pending, Ignored, and Undefined scenarios/tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Performance improvement
  • Refactoring (so no functional change)
  • [X ] Other (docs, build config, etc)

Checklist:

  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@clrudolphi
Copy link
Contributor Author

@gasparnagy Could use your help pointing me in the right direction. Seeing inconsistent results across testing Frameworks.

  • MSTest treats undefined tests as Ignored, but the other frameworks treat them as Pending.
  • For Ignored tests: NUnit counts the number of physical tests (scenarios plus scenario outline example rows), while the other two frameworks count only the number of Scenarios.

Also, would appreciate feedback on the general direction I'm taking here. Is this consistent with your vision for these tests?

@gasparnagy
Copy link
Contributor

@clrudolphi I see. This is a bit more complicated then. I would need to play with that next week to figure out how to move on, so let's suspend this until next week.

…ifferent handling by MSTest.

Adjusted Ignored test to disable row tests; this provides for consistent handling by all three test frameworks.
@clrudolphi
Copy link
Contributor Author

I looked at what Specs did for the same types of tests and adjusted accordingly.

@gasparnagy
Copy link
Contributor

@clrudolphi Thx! Sorry for not being very supportive last week... Spring vs Reqnroll: 1-0 :)

I will take over this and play with it a bit more in the upcoming days.

@gasparnagy
Copy link
Contributor

moved overt to the main repo branch as #99

@gasparnagy gasparnagy closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants