Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to external C++ examples on examples page #4315

Closed
roym899 opened this issue Nov 23, 2023 · 2 comments · Fixed by #4342
Closed

Link to external C++ examples on examples page #4315

roym899 opened this issue Nov 23, 2023 · 2 comments · Fixed by #4342
Assignees
@emilk
Labels
📖 documentation Improvements or additions to documentation examples Issues relating to the Rerun examples 👀 needs triage This issue needs to be triaged by the Rerun team
Milestone
0.11

Comments

@roym899
Copy link
Collaborator

roym899 commented Nov 23, 2023

There are no links to the VRS and OpenCV / Eigen example on the examples page right now.
@roym899 roym899 added 📖 documentation Improvements or additions to documentation other Generated by the "Other" issue template examples Issues relating to the Rerun examples 👀 needs triage This issue needs to be triaged by the Rerun team and removed other Generated by the "Other" issue template labels Nov 23, 2023
@teh-cmc teh-cmc added this to the 0.11 milestone Nov 24, 2023
@emilk emilk self-assigned this Nov 27, 2023
@emilk
Copy link
Member

emilk commented Nov 27, 2023 •
edited
Loading

I wonder under what heading this belongs:

image

VRS is "Real Data" and eigen/opencv is artificial data, but it doesn't feel like a very natural way to split those examples 🤷

@roym899
Copy link
Collaborator Author

roym899 commented Nov 27, 2023 •
edited by emilk
Loading

Hm, I think the headings are a bit odd in general right now. But the way it is, I'd put VRS to Real Data, and the other one to Articifial Data.

emilk added a commit that referenced this issue Nov 27, 2023
@emilk
Add VRS example
6091a68 
Part of #4315
@emilk emilk mentioned this issue Nov 27, 2023
Merged
4 tasks
emilk added a commit that referenced this issue Nov 27, 2023
@emilk
Add more examples to manifest.yml (#4342)
5174435 
* Closes #4315

Adds:
* Open Photogrammetry Example
* External C++ VRS example
* External C++ Eigen/OpenCV exaple

I also opted to sort the examples in lexicographical order because it's
in my DNA to do so.

Check the "Examples preview" below

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4342) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4342)
- [Docs
preview](https://rerun.io/preview/1598cc75e9a913ae43866e2ab570ea9cce0d4110/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/1598cc75e9a913ae43866e2ab570ea9cce0d4110/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
emilk added a commit that referenced this issue Nov 27, 2023
@emilk
Add more examples to manifest.yml (#4342)
3eb4d91 
* Closes #4315

Adds:
* Open Photogrammetry Example
* External C++ VRS example
* External C++ Eigen/OpenCV exaple

I also opted to sort the examples in lexicographical order because it's
in my DNA to do so.

Check the "Examples preview" below

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4342) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4342)
- [Docs
preview](https://rerun.io/preview/1598cc75e9a913ae43866e2ab570ea9cce0d4110/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/1598cc75e9a913ae43866e2ab570ea9cce0d4110/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
📖 documentation Improvements or additions to documentation examples Issues relating to the Rerun examples 👀 needs triage This issue needs to be triaged by the Rerun team
Projects
None yet
Milestone
0.11
Development

Successfully merging a pull request may close this issue.

Add more examples to manifest.yml rerun-io/rerun
3 participants
@emilk @teh-cmc @roym899