Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly uninstalling the files from previous installation #395

Closed
jgalan opened this issue Apr 19, 2023 · 1 comment · Fixed by #397
Closed

Properly uninstalling the files from previous installation #395

jgalan opened this issue Apr 19, 2023 · 1 comment · Fixed by #397
Assignees
@juanangp
Labels
enhancement New feature or request

Comments

@jgalan
Copy link
Member

jgalan commented Apr 19, 2023 •
edited
Loading

After some discussions with @lobis and @juanangp we should try to avoid to completely remove the previous installation directory, in favor of using install_manifest.txt to remove the previous installation files during the make install.

https://gitlab.kitware.com/cmake/community/-/wikis/FAQ#can-i-do-make-uninstall-with-cmake

Just wondering, there is any chance that zombie files keep residing after removing install_manifest.txt files?

This is linked to PR #394
@jgalan jgalan added the enhancement New feature or request label Apr 19, 2023
@juanangp
Copy link
Member

Just wondering, there is any chance that zombie files keep residing after removing install_manifest.txt files?

It seems that the pcm files are still there

@juanangp juanangp self-assigned this Apr 21, 2023
@juanangp juanangp mentioned this issue Apr 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juanangp juanangp

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding uninstall target and proper handling of pcm files rest-for-physics/framework
2 participants
@jgalan @juanangp