Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear-install-dir is performed before add-subdir #394

Merged
merged 1 commit into from
Apr 19, 2023
Merged

clear-install-dir is performed before add-subdir #394

merged 1 commit into from
Apr 19, 2023

Conversation

nkx111
Copy link
Member

@nkx111 nkx111 commented Apr 18, 2023 •
edited
Loading

nkx111 Ok: 10

With the latest version of cmake I found the binary files are not appearing after installation. I found it is caused by the clear-install-dir action which is executed after subdir installation action(with cmake version 3.25.2). So I move forward the corresponding lines in CMakeLists.txt

@jgalan
Copy link
Member

jgalan commented Apr 18, 2023

Ah! Maybe this PR fixes some problems detected on MacOs, perhaps it was related to the cmake version.

https://rest-forum.unizar.es/t/macos-installation-issue-missing-files-headers-bin/573

This was happening only with restG4 I believe.

@heucheld @acorsi

@jgalan jgalan requested review from acorsi, heucheld and jgalan April 18, 2023 21:09
@jgalan jgalan requested review from lobis and juanangp April 19, 2023 08:05
@jgalan jgalan mentioned this pull request Apr 19, 2023
Open
3 tasks
@jgalan jgalan requested a review from a team April 19, 2023 18:23
juanangp
juanangp approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@juanangp juanangp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should remove the install dir every time that we do make install, can you please create an issue about this to follow up the proper handling of removing the install dir

@jgalan jgalan mentioned this pull request Apr 19, 2023
Closed
@jgalan
Copy link
Member

jgalan commented Apr 19, 2023

I don't think we should remove the install dir every time that we do make install, can you please create an issue about this to follow up the proper handling of removing the install dir

Just created

@jgalan jgalan merged commit 06ca238 into master Apr 19, 2023
@jgalan jgalan deleted the nkx111-clear-install-dir branch April 19, 2023 19:18
jgalan added a commit that referenced this pull request May 3, 2023
@jgalan
Revert "Merge pull request #394 from rest-for-physics/nkx111-clear-in…
3733271 
…stall-dir"

This reverts commit 06ca238, reversing
changes made to bb7cdf6.
jgalan added a commit that referenced this pull request May 3, 2023
@jgalan
Revert "Revert "Merge pull request #394 from rest-for-physics/nkx111-…
3e36656 
…clear-install-dir""

This reverts commit 3733271.
This was referenced May 9, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanangp juanangp juanangp approved these changes

@jgalan jgalan jgalan approved these changes

@acorsi acorsi Awaiting requested review from acorsi

@heucheld heucheld Awaiting requested review from heucheld

@lobis lobis Awaiting requested review from lobis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkx111 @jgalan @juanangp