Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding uninstall target and proper handling of pcm files #397

Merged
merged 15 commits into from
May 23, 2023
Merged

Conversation

juanangp
Copy link
Member

@juanangp juanangp commented Apr 21, 2023

juanangp Ok: 53

Uninstall target has been added to cmake, following https://gitlab.kitware.com/cmake/community/-/wikis/FAQ#can-i-do-make-uninstall-with-cmake, to clean up install directories make uninstall can be used.

Moreover, different features have been added:

  • Removal of installation files before install using install_manifest, same as make uninstall instead of removing entire install folder
  • Proper handling of PCM files, which now are added to install_manifest, therefore can be clean up properly

Files left in the install directory after doing make uninstall: rest-config, thisREST.sh and thisREST.csh

Closes #395

@juanangp juanangp requested review from lobis, jgalan and nkx111 April 21, 2023 07:43
@jgalan
Copy link
Member

jgalan commented Apr 21, 2023

Perhaps ROOT pcm are being removed also?

Info in <TCling::LoadPCM>: In-memory ROOT PCM candidate /usr/local/root/install/lib/root/libGviz3d_rdict.pcm
[8321](https://github.com/rest-for-physics/framework/actions/runs/4762628438/jobs/8465184460?pr=397#step:8:8322)

[8322](https://github.com/rest-for-physics/framework/actions/runs/4762628438/jobs/8465184460?pr=397#step:8:8323)
Info in <TCling::LoadPCM>: In-memory ROOT PCM candidate /usr/local/root/install/lib/root/libHistFactory_rdict.pcm
[8323](https://github.com/rest-for-physics/framework/actions/runs/4762628438/jobs/8465184460?pr=397#step:8:8324)

[8324](https://github.com/rest-for-physics/framework/actions/runs/4762628438/jobs/8465184460?pr=397#step:8:8325)
Info in <TCling::LoadPCM>: In-memory ROOT PCM candidate /usr/local/root/install/lib/root/libHistPainter_rdict.pcm
[8325](https://github.com/rest-for-physics/framework/actions/runs/4762628438/jobs/8465184460?pr=397#step:8:8326)

@juanangp
Copy link
Member Author

Perhaps ROOT pcm are being removed also?

I removed by mistake some file permissions, now should be fine.

@juanangp
Copy link
Member Author

I removed by mistake some file permissions, now should be fine.

It seems that this was not the issue, this is annoying because I cannot reproduce the problem in sultan. The pcm files that are removed are generated inside the build directory. But here we just do make install and there is not install_manifest.txt so nothing should be deleted...

CMakeLists.txt Outdated Show resolved Hide resolved
@juanangp juanangp merged commit a9b66be into master May 23, 2023
@juanangp juanangp deleted the uninstall branch May 23, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly uninstalling the files from previous installation
4 participants