-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding uninstall target and proper handling of pcm files #397
Conversation
for more information, see https://pre-commit.ci
Perhaps ROOT pcm are being removed also?
|
I removed by mistake some file permissions, now should be fine. |
It seems that this was not the issue, this is annoying because I cannot reproduce the problem in sultan. The pcm files that are removed are generated inside the build directory. But here we just do |
for more information, see https://pre-commit.ci
Uninstall target has been added to cmake, following https://gitlab.kitware.com/cmake/community/-/wikis/FAQ#can-i-do-make-uninstall-with-cmake, to clean up install directories
make uninstall
can be used.Moreover, different features have been added:
install_manifest
, same asmake uninstall
instead of removing entireinstall
folderinstall_manifest
, therefore can be clean up properlyFiles left in the install directory after doing
make uninstall
:rest-config
,thisREST.sh
andthisREST.csh
Closes #395