TRestMetadata::InitFromConfigFile is now implemented #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But then TRestMetadata would not be an abstract class anymore, with so abstract name it has. |
|
Yes, it can be kept abstract by protecting the constructors. Thats what I did also at the commit |
nkx111
approved these changes
Feb 23, 2022
|
We can remove the repeated code in |
|
There is a difference between both, that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first use case will be at rest-for-physics/axionlib#13 thats why the branch is named
generic_optics.List of changes:
TRestMetadata::InitFromConfigFilehas now been implemented to automatically read basic parameters.REST.confwas updated to include the libraries images path.