Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts PR #244 #288

Closed
wants to merge 1 commit into from
Closed

Reverts PR #244 #288

wants to merge 1 commit into from

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented Sep 1, 2022

jgalan Ok: 53

This reverts commit d1a9e8c, reversing
changes made to 74061eb.

Reverting in order to fix validation of rawlib.

Merging this PR will fix validation at rawlib "solving" issue rest-for-physics/rawlib#74

@jgalan jgalan requested review from nkx111, lobis and juanangp and removed request for nkx111 September 1, 2022 08:27
@jgalan
Copy link
Member Author

jgalan commented Sep 1, 2022

@nkx Perhaps the problem is related to lines around 245 of TRestReflector.h?

@jgalan
Copy link
Member Author

jgalan commented Sep 1, 2022

Closing this PR since there is no need to revert everything, just 1-commit

@jgalan jgalan closed this Sep 1, 2022
@jgalan jgalan deleted the jgalan_reverting_244 branch September 6, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant