Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline failure #74

Closed
juanangp opened this issue Aug 30, 2022 · 11 comments · Fixed by rest-for-physics/framework#289 or #79
Closed

Pipeline failure #74

juanangp opened this issue Aug 30, 2022 · 11 comments · Fixed by rest-for-physics/framework#289 or #79
Assignees
Labels
bug Something isn't working

Comments

@juanangp
Copy link
Member

Pipeline failure in rawlib in stand alone compilation

image

It suddenly start failing on Analysis Process

image

The failure seems related to changes in framework, that I cannot spot.

@juanangp juanangp added the bug Something isn't working label Aug 30, 2022
@jgalan
Copy link
Member

jgalan commented Aug 30, 2022

It is this associated to a particular PR?

@juanangp
Copy link
Member Author

It is this associated to a particular PR?

I cannot spot the associated PR, but apparently should be related with the dictionary generated on-the-fly on TRestReflector

image

@juanangp
Copy link
Member Author

I think might be related with changes on startup.cpp on rest-for-physics/framework#231

@jgalan
Copy link
Member

jgalan commented Aug 30, 2022

I commented something about at this PR #73

@juanangp
Copy link
Member Author

I commented something about at this PR #73

I think the issue was introduced about this time, but not in this PR

I am getting annoyed about this issue, if you compile with rawlib only you get the failure:

cmake ../ -DCMAKE_INSTALL_PREFIX=../install -DRESTLIB_RAW=ON

But when you compile with detectorlib, the pipeline suceed:

cmake ../ -DCMAKE_INSTALL_PREFIX=../install -DRESTLIB_RAW=ON -DRESTLIB_DETECTOR=ON

Anyone has a hint of what is going on? The only difference are the dependencies, when detectorlib is ON rawlib is compiled with this dependency COMPILELIB(deps)

@jgalan
Copy link
Member

jgalan commented Aug 31, 2022

I think might be related with changes on startup.cpp on rest-for-physics/framework#231

The last successful rawlib pipeline validation occured on 19th of June. The PR rest-for-physics/framework#231 was merged on 7th June.

The problem must come later on.

@juanangp
Copy link
Member Author

I just realized that before it was creating the dictionary, but it is not doing it anymore.

image

I don't understand what is going on but it seems that the generation of the dictionary is required while compiling rawlib stand alone but it is not required anymore while detectorlib dependencies are required. Does anyone has any insight?

@jgalan
Copy link
Member

jgalan commented Aug 31, 2022

I just realized that before it was creating the dictionary, but it is not doing it anymore.

Thats what I mentioned at #73

@jgalan
Copy link
Member

jgalan commented Aug 31, 2022

I believe after the following PR it is not passing rawlib pipeline rest-for-physics/framework#263

Inside the framework repository git checkout d42b180 will fail the validation, while git checkout 74061eb will succeed the validation.

Those commits correspond to PR rest-for-physics/framework#263 and rest-for-physics/framework#262

@jgalan
Copy link
Member

jgalan commented Sep 1, 2022

Finally it was rest-for-physics/framework#244

@lobis
Copy link
Member

lobis commented Sep 5, 2022

I think the problem is not fixed yet by rest-for-physics/framework#289 as you can see from https://github.com/rest-for-physics/rawlib/actions/runs/2992398834, which was run after merging the solution @jgalan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants