-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding submodule validation inside framework #371
Conversation
Great I see it is already working here! |
Pipeline should succeed once the following PRs are merged: |
@lobis looks like all submodule validations are failing due to the latest PR to master #376 It seems that these lines are problematic inside the submodule validation.
I have added some changes in submodule validation, please check rest-for-physics/wimplib@d75b74b Let me know if you agree with these changes, validation is passing for wimplib, so I can implement in other submodule pipelines. |
Better check the latest changes on rest-for-physics/wimplib#6 not I have moved the pre-commit config validation to a separate job. |
Issues found on submodule validation pipelines after a merge inside master #368
Adding submodule validation inside framework
Contributes to #372