Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding submodule validation inside framework #371

Merged
merged 11 commits into from
Feb 14, 2023
Merged

Conversation

juanangp
Copy link
Member

@juanangp juanangp commented Feb 9, 2023

juanangp Ok: 60

Issues found on submodule validation pipelines after a merge inside master #368

Adding submodule validation inside framework

Contributes to #372

@juanangp juanangp closed this Feb 9, 2023
@juanangp juanangp reopened this Feb 9, 2023
@juanangp juanangp closed this Feb 9, 2023
@juanangp juanangp reopened this Feb 9, 2023
@jgalan
Copy link
Member

jgalan commented Feb 10, 2023

Great I see it is already working here!

@jgalan
Copy link
Member

jgalan commented Feb 10, 2023

Pipeline should succeed once the following PRs are merged:

rest-for-physics/rawlib#95

#370

@juanangp
Copy link
Member Author

juanangp commented Feb 10, 2023

Pipeline is stuck in GeneralFit.C @lobis can u approve #370

@juanangp juanangp requested a review from lobis February 13, 2023 17:28
@juanangp juanangp changed the title WIP: Testing submodule validation inside framework Adding submodule validation inside framework Feb 13, 2023
@juanangp juanangp marked this pull request as ready for review February 13, 2023 17:30
@juanangp
Copy link
Member Author

@lobis looks like all submodule validations are failing due to the latest PR to master #376

It seems that these lines are problematic inside the submodule validation.

Run cd $GITHUB_WORKSPACE
  cd $GITHUB_WORKSPACE
  curl https://raw.githubusercontent.com/rest-for-physics/framework/master/scripts/validatePreCommitConfig.py | python
  shell: bash --noprofile --norc -e -o pipefail {0}
  env:
    CMAKE_BUILD_TYPE: Release
    REST_PATH: /rest/wimplib/install
    BRANCH_NAME: submodule-validation
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  [2](https://github.com/rest-for-physics/framework/actions/runs/4173229886/jobs/7225311146#step:5:2)611  100  2611    0     0  11627      0 --:--:-- --:--:-- --:--:-- 116[5](https://github.com/rest-for-physics/framework/actions/runs/4173229886/jobs/7225311146#step:5:5)[6](https://github.com/rest-for-physics/framework/actions/runs/4173229886/jobs/7225311146#step:5:6)
fatal: detected dubious ownership in repository at '/__w/framework/framework'
To add an exception for this directory, call:

	git config --global --add safe.directory /__w/framework/framework
Comparing files with branch= in the framework repository.
WARNING: The file .pre-commit-config.yaml is different from the one in the framework repository (branch=).
WARNING: The file .clang-format is different from the one in the framework repository (branch=).
WARNING: The file .cmake-format.yaml is different from the one in the framework repository (branch=).
Error: Process completed with exit code 1.

I have added some changes in submodule validation, please check rest-for-physics/wimplib@d75b74b

Let me know if you agree with these changes, validation is passing for wimplib, so I can implement in other submodule pipelines.

@juanangp
Copy link
Member Author

I have added some changes in submodule validation, please check rest-for-physics/wimplib@d75b74b

Better check the latest changes on rest-for-physics/wimplib#6 not I have moved the pre-commit config validation to a separate job.

@juanangp juanangp merged commit 3e8e1f6 into master Feb 14, 2023
@juanangp juanangp deleted the submodule-validation branch February 14, 2023 18:37
@juanangp juanangp restored the submodule-validation branch February 14, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants