Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low energy EM updates and bug fix #60

Merged
merged 7 commits into from
Aug 29, 2022
Merged

Low energy EM updates and bug fix #60

merged 7 commits into from
Aug 29, 2022

Conversation

lobis
Copy link
Member

@lobis lobis commented Aug 1, 2022

@lobis
Copy link
Member Author

lobis commented Aug 1, 2022

@juanangp the pipeline is failing because of the line:

uses: rest-for-physics/framework/.github/workflows/validation.yml@master

since I have updated the validation.yml at the corresponding branch in framework, but its not merged on master yet (it would need to pass pipeline first...). Any suggestions?

@lobis lobis requested review from juanangp and jgalan and removed request for juanangp August 1, 2022 15:22
@lobis lobis added the bug Something isn't working label Aug 1, 2022
@lobis lobis marked this pull request as ready for review August 1, 2022 15:22
@juanangp
Copy link
Member

juanangp commented Aug 3, 2022

@juanangp the pipeline is failing because of the line:

uses: rest-for-physics/framework/.github/workflows/validation.yml@master

since I have updated the validation.yml at the corresponding branch in framework, but its not merged on master yet (it would need to pass pipeline first...). Any suggestions?

You can change validation.yml on lobis-physics-low-energy framework branch using

uses: rest-for-physics/framework/.github/workflows/validation.yml@lobis-physics-low-energy

Later on, after the merge you can change it to master branch, I think this is the best way to check if the pipeline succeed

@lobis
Copy link
Member Author

lobis commented Aug 3, 2022

@juanangp the pipeline is failing because of the line:

uses: rest-for-physics/framework/.github/workflows/validation.yml@master

since I have updated the validation.yml at the corresponding branch in framework, but its not merged on master yet (it would need to pass pipeline first...). Any suggestions?

You can change validation.yml on lobis-physics-low-energy framework branch using

uses: rest-for-physics/framework/.github/workflows/validation.yml@lobis-physics-low-energy

Later on, after the merge you can change it to master branch, I think this is the best way to check if the pipeline succeed

I did as you suggested and commit 14e5e3c shows that it works. I will revert these changes.

@lobis lobis merged commit 52905a6 into master Aug 29, 2022
@lobis lobis deleted the lobis-physics-low-energy branch August 29, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants