Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing problems with RML parameters in TRestRawSignalChannelActivity #73

Merged
merged 4 commits into from
Sep 10, 2022

Conversation

cmargalejo
Copy link
Member

@cmargalejo cmargalejo commented Jul 27, 2022

cmargalejo Ok: 28

Solving some of the problems that were discussed in PR #72

@jgalan
Copy link
Member

jgalan commented Jul 27, 2022

Hi, the pipeline is failing because the veto observable vetoRaw_max_amplitude_map is not anymore between the observables inside the analysisTree.

In previous versions where it was working, it seems the dictionary was being generated on the fly.

Creating external dictionary for: "map<int,double>":
[105](https://gitlab.cern.ch/rest-for-physics/rawlib/-/jobs/22648438#L105)/builds/rest-for-physics/rawlib/install//.rest/AddonDict/Dict_map_int_double_.so

Now, when running the same processing, the observable will not be added:

In TRestReflector::TRestReflector() : unrecognized type: "map<int,double>"
Error adding observable "vetoRaw_max_amplitude_map" with type "map<int,double>", type not found!

It was the automatic generation disabled? Should we add it now manually? @nkx @juanangp @lobis

@jgalan jgalan self-requested a review September 10, 2022 10:40
@jgalan jgalan marked this pull request as ready for review September 10, 2022 10:40
@jgalan jgalan merged commit 7fe75c1 into master Sep 10, 2022
@jgalan jgalan deleted the cristina_rawActivity branch September 10, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants