Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Violet Rails iOS support #820

Open
donrestarone opened this issue Jun 26, 2022 · 1 comment
Open

Violet Rails iOS support #820

donrestarone opened this issue Jun 26, 2022 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@donrestarone
Copy link
Contributor

donrestarone commented Jun 26, 2022 •
edited
Loading

Violet Rails harmonized apps (web and native)

Client detection

As of Version 0.9.5 (https://github.com/restarone/violet_rails/releases/tag/0.9.5) the only officially recognized mobile client is iOS (VioletRailsiOS). Clients that set the user agent VioletRailsiOS are detected under the mobile? flag.

Conditional rendering

For native clients web navbar and footer are hidden in favour of native navigation (currently WIP (restarone/violet_rails_ios_client#1) to dynamically set tab navigation / other navigational elements from Violet Rails API Namespace)

known issues

  1. Forum login is not seamless (view is broken until the forum view is revisited due to turbo / http request change)
  2. Forum images/assets not loading (perhaps due to strict HTTPS rules?)
  3. 2FA screen not working

Pull request that made Violet Mobile Native aware: #819

iOS client repo: https://github.com/restarone/violet_rails_ios_client
@donrestarone donrestarone added the documentation Improvements or additions to documentation label Jun 26, 2022
@donrestarone donrestarone changed the title document Violet Rails iOS support Violet Rails iOS support Jun 26, 2022
@donrestarone
Copy link
Contributor Author

App Store review:

Screen Shot 2023-04-21 at 3 32 13 PM

@donrestarone donrestarone mentioned this issue Apr 25, 2023
Merged
donrestarone pushed a commit that referenced this issue Apr 29, 2023
@Pralish
[feature] Turbo Drive and Sessions in iOS (#1542)
86db27d 
Addresses: #1414 & #820
@donrestarone donrestarone mentioned this issue Apr 29, 2023
Merged
donrestarone added a commit that referenced this issue Apr 29, 2023
@donrestarone @Pralish
[feature] Turbo Drive and Sessions in iOS (#1542) (#1547)
2e684c6 
Addresses: #1414 & #820

Addresses: #1414 & #820

## Allow login on iOS

<img width="503" alt="Screen Shot 2023-04-28 at 10 38 00 PM" src="https://user-images.githubusercontent.com/35935196/235279807-f985c695-07d4-40b5-a8dc-26aa7e045286.png">

## Access Forum, Web app and Admin Index 
<img width="496" alt="Screen Shot 2023-04-28 at 10 37 39 PM" src="https://user-images.githubusercontent.com/35935196/235279808-7d061262-318a-408c-8eec-896365d69359.png">



Co-authored-by: Pralish Kayastha <50227291+Pralish@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@donrestarone