[feature] make server turbo native ready #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make Turbo available to the window * dont show navbar/footer if mobile * add safe navigation to mobile? * hide web navbar on devise pages + forum * render smart nav/footers Co-authored-by: donrestarone <shashikejayatunge@gmail.co>
donrestarone
changed the title
donrestarone
added
the
Passing UAT on Staging ✅
|
to-do:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #817
client repository
iOS project: https://github.com/restarone/violet_rails_ios_client
upgrade path
replace
{{ cms:snippet navbar }}and{{ cms:snippet footer }}with{{cms:helper render_smart_navbar}}and{{cms:helper render_smart_footer}}. These new functions will intelligently render navbar/footer as{{ cms:snippet navbar }}and{{ cms:snippet footer }}for web clients. We don't want to show web navigation on native clientsiOS support
Your Violet Rails app will now look like this on iOS
how the app looks
native navigation
web navbar is not shown, instead a system tray is shown at the bottom with relevant navigation buttons
Blog
Forum