Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk-java templates #42

Closed
wants to merge 11 commits into from
Closed

sdk-java templates #42

wants to merge 11 commits into from

Conversation

slinkydeveloper
Copy link
Contributor

Copy link
Contributor

@pcholakov pcholakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor non-blocking comments, LGTM! 🚢

Should we add license headers to the handler source files?

jvm/java-blocking-http/build.gradle.kts Show resolved Hide resolved
Comment on lines +17 to +19
companion object {
private val COUNT = StateKey.of("count", CoreSerdes.INT)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I was going to comment that a companion object is a more Kotlin-idiomatic way of declaring constants :-)

@slinkydeveloper
Copy link
Contributor Author

For the headers we have another open issue #10. Can tackle it there.

@slinkydeveloper
Copy link
Contributor Author

TODO: update module names and packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template gradle project
2 participants