Java templates and release #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
force-pushed
the
java-templates-and-release
branch
5 times, most recently
from
1055c4e
to
432d420
Compare
slinkydeveloper
force-pushed
the
java-templates-and-release
branch
from
432d420
to
c5b3714
Compare
tillrohrmann
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Thanks for creating this PR @slinkydeveloper. I've given it a pass and left some minor comments. The main comment (unfortunately I don't have a good idea for how to solve it) is that with the download commands in the root readme, the readme becomes quite cluttered. Maybe this is fine for the time being. Apart from that, I think it would be helpful to add a bit more comments to the starter examples to guide new Restate users.
java/hello-world-lambda/src/main/java/dev/restate/sdk/examples/Greeter.java
Outdated
Show resolved
Hide resolved
java/hello-world-lambda/src/main/java/dev/restate/sdk/examples/LambdaHandler.java
Outdated
Show resolved
Hide resolved
slinkydeveloper
force-pushed
the
java-templates-and-release
branch
from
535ca28
to
b0c0918
Compare
tillrohrmann
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of #42 and #43