Fix #516: Option to fully highlight wrapped-lines #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves the issue while still mantaining the current behaviour.
Changes:
· ReText/__init__.py
Change default value of highlightCurrentLine to 'disabled'.
· ReText/config.py
Add a combobox for the line highlighting setting with options:
- "Disabled": no line highlighting;
- "Cursor Line": line highlighting till EOL (current behaviour);
- "Wrapped Line": line highlighting for whole wrapped line.
· ReText/editor.py
Modify highlightCurrentLine() to achieve the intended behaviour.
mitya57
requested changes
Aug 6, 2020
* ReText/editor.py
- Remove semicolon.
- Remove unnecessary selection for option "wrapped-line".
|
All done. I was just noticing that in highlightCurrentLine() there are some repeated lines of code regarding the creation of the selection and the setting of background and property of the selection. I think the code could be refactored a bit. |
|
Yes, feel free to refactor it. If it's not possible to fix the last line case without two selections, feel free to revert the second one. |
ghost
marked this pull request as draft
- Revert removal of second selection used for wrapped-lines. - Refactor highlightCurrentLine().
ghost
marked this pull request as ready for review
|
Done. Reverted to the precedent solution and refactored the function a bit. |
|
Merged, thanks! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the title, this will resolve #516, giving the option to fully highlight the wrapped-line under the cursor, or only the single line under the cursor (current behaviour).