Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #516: Option to fully highlight wrapped-lines #523

Merged
merged 4 commits into from Aug 7, 2020
Merged

Fix #516: Option to fully highlight wrapped-lines #523

merged 4 commits into from Aug 7, 2020

Commits on Aug 6, 2020

  1. Fix #516: Option to fully highlight wrapped-lines

    This commit resolves the issue while still mantaining the current behaviour.
    
    Changes:
    · ReText/__init__.py
        Change default value of highlightCurrentLine to 'disabled'.
    · ReText/config.py
        Add a combobox for the line highlighting setting with options:
            - "Disabled": no line highlighting;
            - "Cursor Line": line highlighting till EOL (current behaviour);
            - "Wrapped Line": line highlighting for whole wrapped line.
    · ReText/editor.py
        Modify highlightCurrentLine() to achieve the intended behaviour.
    nihillum committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    ad7c9ce View commit details
    Browse the repository at this point in the history
  2. Requested changes

    * ReText/editor.py
        - Remove semicolon.
        - Remove unnecessary selection for option "wrapped-line".
    nihillum committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    9edd05e View commit details
    Browse the repository at this point in the history
  3. Revert changes

    - Revert removal of second selection used for wrapped-lines.
    - Refactor highlightCurrentLine().
    nihillum committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    3f2f869 View commit details
    Browse the repository at this point in the history
  4. Remove useless else block

    nihillum committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    64d0f90 View commit details
    Browse the repository at this point in the history