Make adapters responsible for determining which hash algorithm has been used for message signing #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redefine #compute_signature in every adapter, so that an array composed of hash algorithm name and actual signature is returned, instead of only signature.
houndci-bot
reviewed
Sep 4, 2018
lib/enmail/helpers/rfc1847.rb
Outdated
| def multipart_signed_content_type | ||
| protocol = sign_protocol | ||
| micalg = message_integrity_algorithm | ||
| def multipart_signed_content_type(protocol: sign_protocol, micalg: message_integrity_algorithm) |
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 99.91% 99.91% +<.01%
==========================================
Files 37 37
Lines 1204 1237 +33
==========================================
+ Hits 1203 1236 +33
Misses 1 1
Continue to review full report at Codecov.
|
Use digest algorithm namereturned by adapter when setting "multipart/signed" content type.
skalee
force-pushed
the
one-pass-compat
branch
from
5768682 to
cb4e303
Compare
Message integrity algorithm (micalg) is now required to be returned from #compute_signature method, hence any defaults are pointless.
skalee
force-pushed
the
one-pass-compat
branch
from
cb4e303 to
cb81073
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC1847, a "multipart/signed" MIME type must be supplied with "micalg" parameter, which tells which hash algorithm has been used in signature calculation. Whereas signature part contains this information as well, declaring this in advance allows for signature verification in one-pass processing.
Fixes #101.