remove warning to tell user to set requiresMainQueueSetup (facebook#4…

…1294) Summary: Pull Request resolved: facebook#41294 Changelog: [Internal] i believe this warning is outdated, i don't think having a custom initializer or exporting constants means that your module needs to be setup on main. Reviewed By: cipolleschi Differential Revision: D50919152 fbshipit-source-id: dc91af5fc88eca4f07a5f35adb888160b978cc38
rigdern · Feb 22, 2024 · ea04463 · ea04463
1 parent f7bac14
commit ea04463
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 27 deletions.
diff --git a/packages/react-native/React/Base/RCTModuleData.mm b/packages/react-native/React/Base/RCTModuleData.mm
@@ -77,20 +77,6 @@ - (void)setUp
         !_instance && [_moduleClass instanceMethodForSelector:@selector(init)] != objectInitMethod;
 
     _requiresMainQueueSetup = _hasConstantsToExport || hasCustomInit;
-    if (_requiresMainQueueSetup) {
-      const char *methodName = "";
-      if (_hasConstantsToExport) {
-        methodName = "constantsToExport";
-      } else if (hasCustomInit) {
-        methodName = "init";
-      }
-      RCTLogWarn(
-          @"Module %@ requires main queue setup since it overrides `%s` but doesn't implement "
-           "`requiresMainQueueSetup`. In a future release React Native will default to initializing all native modules "
-           "on a background thread unless explicitly opted-out of.",
-          _moduleClass,
-          methodName);
-    }
   }
 }
 

diff --git a/...ive/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.mm b/...ive/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.mm
@@ -879,19 +879,7 @@ - (BOOL)_requiresMainQueueSetup:(Class)moduleClass
    */
   const BOOL hasCustomInit = [moduleClass instanceMethodForSelector:@selector(init)] != objectInitMethod;
 
-  BOOL requiresMainQueueSetup = hasConstantsToExport || hasCustomInit;
-  if (requiresMainQueueSetup) {
-    RCTLogWarn(
-        @"Module %@ requires main queue setup since it overrides `%s` but doesn't implement "
-         "`requiresMainQueueSetup`. In a future release React Native will default to initializing all NativeModules "
-         "on a background thread unless explicitly opted-out of.",
-        moduleClass,
-        hasConstantsToExport ? "constantsToExport"
-            : hasCustomInit  ? "init"
-                             : "");
-  }
-
-  return requiresMainQueueSetup;
+  return hasConstantsToExport || hasCustomInit;
 }
 
 - (void)installJSBindings:(facebook::jsi::Runtime &)runtime