Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plan_node_fmt): further prepare generic code where they use fmt_with_builder #10155

Merged
merged 10 commits into from
Jun 5, 2023

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Jun 5, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This is a folllow up of #10132.

Checklist For Contributors

  • Yes

Documentation

  • My PR DOES NOT contain user-facing changes.

@ice1000 ice1000 requested a review from st1page June 5, 2023 04:06
@ice1000 ice1000 enabled auto-merge June 5, 2023 04:06
@ice1000 ice1000 added this pull request to the merge queue Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #10155 (d52614c) into main (2e33fef) will decrease coverage by 0.03%.
The diff coverage is 30.08%.

@@            Coverage Diff             @@
##             main   #10155      +/-   ##
==========================================
- Coverage   70.88%   70.86%   -0.03%     
==========================================
  Files        1234     1234              
  Lines      211234   211316      +82     
==========================================
+ Hits       149734   149740       +6     
- Misses      61500    61576      +76     
Flag Coverage Δ
rust 70.86% <30.08%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/optimizer/plan_node/generic/filter.rs 83.67% <0.00%> (-16.33%) ⬇️
...tend/src/optimizer/plan_node/generic/hop_window.rs 80.26% <0.00%> (-12.87%) ⬇️
...ntend/src/optimizer/plan_node/generic/intersect.rs 54.16% <0.00%> (-7.74%) ⬇️
...rc/frontend/src/optimizer/plan_node/generic/mod.rs 0.00% <0.00%> (ø)
.../frontend/src/optimizer/plan_node/generic/union.rs 91.17% <0.00%> (-8.83%) ⬇️
...rc/frontend/src/optimizer/plan_node/generic/agg.rs 82.64% <40.00%> (-3.18%) ⬇️
...rontend/src/optimizer/plan_node/generic/project.rs 97.16% <77.27%> (-2.35%) ⬇️
.../src/optimizer/plan_node/generic/dynamic_filter.rs 96.92% <100.00%> (+0.07%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants