Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plan_node_fmt): only 9 types are left!! #10359

Merged
merged 4 commits into from
Jun 21, 2023
Merged

refactor(plan_node_fmt): only 9 types are left!! #10359

merged 4 commits into from
Jun 21, 2023

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Jun 15, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This is a folllllllllow up of #10132, #10155, #10157, #10253, #10280, #10281, #10291, #10296, #10344.

Checklist For Contributors

  • Yes

@github-actions github-actions bot added Invalid PR Title user-facing-changes Contains changes that are visible to users labels Jun 15, 2023
@ice1000 ice1000 changed the title 6 refactor(plan_node_fmt): only 9 types are left!! Jun 15, 2023
6
Much more

More

Pulp: Common people
@ice1000 ice1000 removed the user-facing-changes Contains changes that are visible to users label Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #10359 (b588030) into main (43458ef) will decrease coverage by 0.03%.
The diff coverage is 10.15%.

@@            Coverage Diff             @@
##             main   #10359      +/-   ##
==========================================
- Coverage   70.51%   70.48%   -0.03%     
==========================================
  Files        1260     1260              
  Lines      215075   215137      +62     
==========================================
- Hits       151651   151636      -15     
- Misses      63424    63501      +77     
Flag Coverage Δ
rust 70.48% <10.15%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/frontend/src/optimizer/plan_node/batch_values.rs 93.44% <0.00%> (+12.01%) ⬆️
.../src/optimizer/plan_node/generic/dynamic_filter.rs 91.97% <0.00%> (-4.96%) ⬇️
...rc/frontend/src/optimizer/plan_node/logical_now.rs 61.22% <0.00%> (+6.67%) ⬆️
...frontend/src/optimizer/plan_node/logical_values.rs 90.18% <0.00%> (-1.70%) ⬇️
.../frontend/src/optimizer/plan_node/stream_expand.rs 0.00% <ø> (ø)
.../frontend/src/optimizer/plan_node/stream_filter.rs 97.36% <ø> (ø)
...ntend/src/optimizer/plan_node/stream_hop_window.rs 93.22% <0.00%> (-5.88%) ⬇️
...tend/src/optimizer/plan_node/stream_project_set.rs 74.00% <ø> (ø)
...ntend/src/optimizer/plan_node/stream_row_id_gen.rs 88.88% <0.00%> (-8.68%) ⬇️
...rc/frontend/src/optimizer/plan_node/stream_sort.rs 93.67% <0.00%> (-5.00%) ⬇️
... and 10 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ice1000 ice1000 added this pull request to the merge queue Jun 21, 2023
Merged via the queue into main with commit bd150ec Jun 21, 2023
@ice1000 ice1000 deleted the tesla/dog branch June 21, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants