Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add some comments / move some code #10912

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jul 12, 2023

picked from #10910

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR contains user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@xxchan xxchan enabled auto-merge July 12, 2023 09:26
@xxchan xxchan disabled auto-merge July 12, 2023 09:26
@xxchan
Copy link
Member Author

xxchan commented Jul 12, 2023

weird 👀 cc @kwannoel

image

@kwannoel
Copy link
Contributor

kwannoel commented Jul 12, 2023

weird 👀 cc @kwannoel

image

Could be #10913?

Saw some failure in Dylan's recent PR also and this was the cause. Can just rerun

Copy link
Contributor

@Gun9niR Gun9niR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the system param part. Thanks!

Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the UDF part.

@xxchan xxchan enabled auto-merge July 12, 2023 12:07
@xxchan
Copy link
Member Author

xxchan commented Jul 12, 2023

😇 again @kwannoel

image

@xxchan
Copy link
Member Author

xxchan commented Jul 12, 2023

🤔 wrong result in e2e-parallel streaming/tpch_snapshot

https://buildkite.com/risingwavelabs/pull-request/builds/27243#01894a31-63c6-4fa0-9575-882d0883a89e

image

@xxchan xxchan added this pull request to the merge queue Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #10912 (6c74937) into main (dc6f647) will increase coverage by 0.00%.
The diff coverage is 11.23%.

@@           Coverage Diff           @@
##             main   #10912   +/-   ##
=======================================
  Coverage   69.96%   69.97%           
=======================================
  Files        1307     1307           
  Lines      223292   223292           
=======================================
+ Hits       156237   156241    +4     
+ Misses      67055    67051    -4     
Flag Coverage Δ
rust 69.97% <11.23%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/udf/src/external.rs 0.00% <0.00%> (ø)
src/common/src/system_param/mod.rs 85.81% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 376b266 Jul 12, 2023
@xxchan xxchan deleted the xxchan/rolling-mastodon branch July 12, 2023 16:09
kwannoel added a commit that referenced this pull request Jul 14, 2023
Co-authored-by: Noel Kwan <noelkwan1998@gmail.com>
Co-authored-by: Noel Kwan <47273164+kwannoel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants