-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add some comments / move some code #10912
Conversation
picked from #10910
weird 👀 cc @kwannoel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the system param part. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the UDF part.
😇 again @kwannoel |
🤔 wrong result in e2e-parallel streaming/tpch_snapshot https://buildkite.com/risingwavelabs/pull-request/builds/27243#01894a31-63c6-4fa0-9575-882d0883a89e |
Codecov Report
@@ Coverage Diff @@
## main #10912 +/- ##
=======================================
Coverage 69.96% 69.97%
=======================================
Files 1307 1307
Lines 223292 223292
=======================================
+ Hits 156237 156241 +4
+ Misses 67055 67051 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Noel Kwan <noelkwan1998@gmail.com> Co-authored-by: Noel Kwan <47273164+kwannoel@users.noreply.github.com>
picked from #10910
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note