-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sqlsmith): ban tables with invalid columns for window functions #10913
Conversation
window_start
and window_end
columns for window functions
Codecov Report
@@ Coverage Diff @@
## main #10913 +/- ##
=======================================
Coverage 69.96% 69.97%
=======================================
Files 1307 1307
Lines 223292 223292
=======================================
+ Hits 156237 156241 +4
+ Misses 67055 67051 -4
Flags with carried forward coverage won't be shown. Click here to find out more. see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
May still need a further fix after this PR, which is to make sure gen hop and gen tumble add window_start and window_end to their columns. EDIT: actually not so straightforward. There could be hidden columns as a result of group_by. Those may not be |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Related: #10516
This PR bans relations like
CREATE table t (v1 timestamp, window_start timestamp)
from being used when generatinghop
andtumble
functions.Done by filtering out any tables with
window_start / window_end
when selecting candidate relations for hop and tumble.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note