Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(etcd): patch etcd-client to unlimit message size #11277

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

wangrunji0408
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

After upgrading tonic to v0.9 #11088, meta service failed to get data larger than 4MB from etcd. Etcd-client hasn't exposed any interface to change the limit. So we have to fork etcd-client and remove this limit.

risingwavelabs/etcd-client@d55550a

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR contains user-facing changes.

@github-actions github-actions bot added the type/fix Bug fix label Jul 27, 2023
Signed-off-by: Runji Wang <wangrunji0408@163.com>
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #11277 (600da62) into main (317d5a1) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #11277   +/-   ##
=======================================
  Coverage   69.66%   69.66%           
=======================================
  Files        1355     1355           
  Lines      224882   224882           
=======================================
+ Hits       156660   156666    +6     
+ Misses      68222    68216    -6     
Flag Coverage Δ
rust 69.66% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 92ff4cd Jul 27, 2023
5 of 6 checks passed
@yezizp2012 yezizp2012 deleted the wrj/patch-etcd-client branch July 27, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants