Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): use upstream version of etcd-client #17648

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

We switched to a forked version of etcd-client in #11277. Later, the upstream version resolved the issue (etcdv3/etcd-client#69) so I guess we can switch back to it.

This is a preparation of #13695 (comment).

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@BugenZhao BugenZhao requested a review from xxchan July 10, 2024 08:42
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao enabled auto-merge July 11, 2024 07:25
@BugenZhao BugenZhao added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 2ad3d87 Jul 11, 2024
32 of 33 checks passed
@BugenZhao BugenZhao deleted the bz/upstream-etcd-client branch July 11, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants