fix(test): skip creating secret file dir in simulation test #17772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Creating secret directories will cause file creation conflict in concurrent simulation tests.
This will not happen in any deployment because we use cluster id (uuid) to distinguish files from different cluster. But we are running
deterministic-it-test.sh
concurrently, and nextest is running multiple ut concurrently. So even with different madsim seed for each deterministic-it-test.sh, two ut in the same run share the same seed, causing the same uuid in different cluster (bc madsim hook the random function in uuid::new_v4)We currently do not have e2e for secret file. Should skip testing secret files in simulation tests if we have in the future.
close #17740
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.