Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): skip creating secret file dir in simulation test #17772

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

yuhao-su
Copy link
Contributor

@yuhao-su yuhao-su commented Jul 22, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Creating secret directories will cause file creation conflict in concurrent simulation tests.

This will not happen in any deployment because we use cluster id (uuid) to distinguish files from different cluster. But we are running deterministic-it-test.sh concurrently, and nextest is running multiple ut concurrently. So even with different madsim seed for each deterministic-it-test.sh, two ut in the same run share the same seed, causing the same uuid in different cluster (bc madsim hook the random function in uuid::new_v4)

We currently do not have e2e for secret file. Should skip testing secret files in simulation tests if we have in the future.

close #17740

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Jul 22, 2024
@graphite-app graphite-app bot requested a review from a team July 22, 2024 18:09
Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@yuhao-su yuhao-su added this pull request to the merge queue Jul 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 23, 2024
@xxchan xxchan added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit 69caf47 Jul 23, 2024
36 of 38 checks passed
@xxchan xxchan deleted the yuhao/fix-secret-concurrent-test branch July 23, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: secret manager panic at { code: 17, kind: AlreadyExists, message: "File exists" }
3 participants