Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): skip creating secret file dir in simulation test #17772

Merged
merged 1 commit into from
Jul 23, 2024
+7 −0
Merged

fix(test): skip creating secret file dir in simulation test #17772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/common/secret/src/secret_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ impl LocalSecretManager {
.join(cluster_id)
.join(worker_id.to_string());
std::fs::remove_dir_all(&secret_file_dir).ok();

// This will cause file creation conflict in simulation tests.
// Should skip testing secret files in simulation tests.
#[cfg(not(madsim))]
std::fs::create_dir_all(&secret_file_dir).unwrap();

Self {
Expand Down Expand Up @@ -87,7 +91,10 @@ impl LocalSecretManager {
"Failed to remove secret directory")
})
.ok();

#[cfg(not(madsim))]
std::fs::create_dir_all(&self.secret_file_dir).unwrap();

for secret in secrets {
secret_guard.insert(secret.id, secret.value);
}
Expand Down
Loading