Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metadata v2): existing actor splits were not updated #18553

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Sep 17, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title.

This is the root cause of duplicated source splits. Resolves #16235.

  1. Assume there is only 1 source split and 4 source actors at the beginning.
  2. Run alter materialized view ... set parallelism = 8. There is 50% chance that the only 1 split is assigned to a new actor.
  3. Because of this bug, the old actor's split assignment was not updated, causing duplication.
  4. Once recovery or restarts, the duplicated splits will cause duplicated state table writes, causing assertion failure of bug: dedicated cdc source writes the same full key more than once in an epoch #16235.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks!

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ideally we can add some assertions (maybe after scaling/after recovery) to ensure actor_splits is consistent.

And in the future we can avoid persisting actor_splits to reduce complexity and inconsistencies.

@fuyufjh fuyufjh enabled auto-merge September 17, 2024 06:12
@fuyufjh fuyufjh added this pull request to the merge queue Sep 17, 2024
@fuyufjh fuyufjh mentioned this pull request Sep 17, 2024
9 tasks
Merged via the queue into main with commit 11ad34b Sep 17, 2024
40 of 41 checks passed
@fuyufjh fuyufjh deleted the eric/fix_dup_source_splits branch September 17, 2024 06:39
github-merge-queue bot pushed a commit that referenced this pull request Sep 18, 2024
…8555)

Co-authored-by: Eric Fu <eric@singularity-data.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: dedicated cdc source writes the same full key more than once in an epoch
4 participants