Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add recovery in nexmark q4 sim test #18577

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Sep 18, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title. Motivated by #18553.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@fuyufjh fuyufjh requested a review from shanicky September 18, 2024 06:38
@github-actions github-actions bot added the component/test Test related issue. label Sep 18, 2024
@fuyufjh
Copy link
Member Author

fuyufjh commented Sep 18, 2024

@shanicky I produced an assertion failure on this branch. 😂 Can you please take a look?

MADSIM_TEST_SEED=1726640506958974000 ./risedev sit-test nexmark_q4_materialize_agg_with_recovery
failures:
    scale::nexmark_q4::nexmark_q4_materialize_agg_with_recovery

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 114 filtered out; finished in 40.08s


--- STDERR:              risingwave_simulation::integration_tests scale::nexmark_q4::nexmark_q4_materialize_agg_with_recovery ---
thread '<unnamed>' panicked at src/meta/src/stream/scale.rs:1590:21:
assertion failed: actor_ids.len() >= n
stack backtrace:
   0: rust_begin_unwind
             at /rustc/5affbb17153bc69a9d5d8d2faa4e399a014a211e/library/std/src/panicking.rs:665:5
   1: core::panicking::panic_fmt
             at /rustc/5affbb17153bc69a9d5d8d2faa4e399a014a211e/library/core/src/panicking.rs:74:14
   2: core::panicking::panic
             at /rustc/5affbb17153bc69a9d5d8d2faa4e399a014a211e/library/core/src/panicking.rs:148:5
   3: risingwave_meta::stream::scale::ScaleController::arrange_reschedules::{{closure}}
             at /Users/eric/Workspace/risingwave/src/meta/src/stream/scale.rs:1590:21
   4: risingwave_meta::stream::scale::ScaleController::analyze_reschedule_plan::{{closure}}
             at /Users/eric/Workspace/risingwave/src/meta/src/stream/scale.rs:968:58
   5: risingwave_meta::stream::scale::<impl risingwave_meta::stream::stream_manager::GlobalStreamManager>::reschedule_actors_impl::{{closure}}
             at /Users/eric/Workspace/risingwave/src/meta/src/stream/scale.rs:2530:14
   6: risingwave_meta::stream::scale::<impl risingwave_meta::stream::stream_manager::GlobalStreamManager>::reschedule_actors::{{closure}}
             at /Users/eric/Workspace/risingwave/src/meta/src/stream/scale.rs:2507:14
   7: <risingwave_meta_service::scale_service::ScaleServiceImpl as risingwave_pb::meta::scale_service_server::ScaleService>::reschedule::{{closure}}
             at /Users/eric/Workspace/risingwave/src/meta/service/src/scale_service.rs:214:14
   8: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/5affbb17153bc69a9d5d8d2faa4e399a014a211e/library/core/src/future/future.rs:123:9
   9: <risingwave_pb::meta::scale_service_server::ScaleServiceServer<T,F> as tower_service::Service<(http::uri::path::PathAndQuery,tonic::request::Request<core::pin::Pin<alloc::boxed::Box<dyn futures_core::stream::Stream+Item = core::result::Result<alloc::boxed::Box<dyn core::any::Any+core::marker::Sync+core::marker::Send>,tonic::status::Status>+core::marker::Send>>>)>>::call::{{closure}}
             at /Users/eric/Workspace/risingwave/src/prost/src/sim/meta.rs:4242:30
  10: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/5affbb17153bc69a9d5d8d2faa4e399a014a211e/library/core/src/future/future.rs:123:9
  11: <tracing::instrument::Instrumented<T> as core::future::future::Future>::poll
             at /Users/eric/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tracing-0.1.40/src/instrument.rs:321:9
  12: madsim_tonic::sim::transport::server::Router<L>::serve_with_shutdown::{{closure}}::{{closure}}::{{closure}}
             at /Users/eric/.cargo/registry/src/index.crates.io-6f17d22bba15001f/madsim-tonic-0.5.1+0.12.0/src/transport/server.rs:277:57
  13: madsim::sim::task::Spawner::spawn_inner::{{closure}}::{{closure}}
             at /Users/eric/.cargo/registry/src/index.crates.io-6f17d22bba15001f/madsim-0.2.30/src/sim/task/mod.rs:638:28
  14: <async_task::runnable::Builder<M>::spawn_local::Checked<F> as core::future::future::Future>::poll
             at /Users/eric/.cargo/registry/src/index.crates.io-6f17d22bba15001f/async-task-4.4.0/src/runnable.rs:455:26
  15: async_task::raw::RawTask<F,T,S,M>::run
             at /Users/eric/.cargo/registry/src/index.crates.io-6f17d22bba15001f/async-task-4.4.0/src/raw.rs:563:17
  16: async_task::runnable::Runnable<M>::run
             at /Users/eric/.cargo/registry/src/index.crates.io-6f17d22bba15001f/async-task-4.4.0/src/runnable.rs:782:18
  17: madsim::sim::task::Executor::run_all_ready::{{closure}}
             at /Users/eric/.cargo/registry/src/index.crates.io-6f17d22bba15001f/madsim-0.2.30/src/sim/task/mod.rs:280:50
  18: std::panicking::try::do_call
             at /rustc/5affbb17153bc69a9d5d8d2faa4e399a014a211e/library/std/src/panicking.rs:557:40
  19: ___rust_try
  20: std::panicking::try
             at /rustc/5affbb17153bc69a9d5d8d2faa4e399a014a211e/library/std/src/panicking.rs:521:19
  21: std::panic::catch_unwind
             at /rustc/5affbb17153bc69a9d5d8d2faa4e399a014a211e/library/std/src/panic.rs:350:14
  22: madsim::sim::task::Executor::run_all_ready
             at /Users/eric/.cargo/registry/src/index.crates.io-6f17d22bba15001f/madsim-0.2.30/src/sim/task/mod.rs:280:17
  23: madsim::sim::task::Executor::block_on
             at /Users/eric/.cargo/registry/src/index.crates.io-6f17d22bba15001f/madsim-0.2.30/src/sim/task/mod.rs:240:13
  24: madsim::sim::runtime::Runtime::block_on
             at /Users/eric/.cargo/registry/src/index.crates.io-6f17d22bba15001f/madsim-0.2.30/src/sim/runtime/mod.rs:129:9
  25: madsim::sim::runtime::builder::Builder::run::{{closure}}::{{closure}}::{{closure}}
             at /Users/eric/.cargo/registry/src/index.crates.io-6f17d22bba15001f/madsim-0.2.30/src/sim/runtime/builder.rs:141:35
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
context: node=6 "meta-3", task=3599 (spawned at /Users/eric/.cargo/registry/src/index.crates.io-6f17d22bba15001f/madsim-tonic-0.5.1+0.12.0/src/transport/server.rs:275:13)
note: run with `MADSIM_TEST_SEED=1726640506958974000` environment variable to reproduce this error

@fuyufjh
Copy link
Member Author

fuyufjh commented Oct 15, 2024

Ping @shanicky any updates?

@shanicky shanicky force-pushed the eric/add_recovery_in_nexmark_source_sim_test branch 2 times, most recently from f73d4e4 to a22ad40 Compare October 15, 2024 11:40
…ing tests.

Signed-off-by: Shanicky Chen <peng@risingwave-labs.com>
@shanicky shanicky force-pushed the eric/add_recovery_in_nexmark_source_sim_test branch from a22ad40 to d7f0643 Compare October 15, 2024 13:44
@fuyufjh fuyufjh added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 6863a24 Oct 16, 2024
29 of 30 checks passed
@fuyufjh fuyufjh deleted the eric/add_recovery_in_nexmark_source_sim_test branch October 16, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants