fix(test): fix some flaky e2e source tests #18989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
xxchan
changed the title
stdrc
approved these changes
Oct 18, 2024
BugenZhao
approved these changes
Oct 18, 2024
| @@ -14,6 +14,8 @@ EOF | |||
| statement ok | |||
| ALTER SYSTEM SET license_key TO ''; | |||
|
|
|||
| sleep 1s | |||
There was a problem hiding this comment.
There are also many other occurrences which may explode in the coming days, I suppose. 🤣
It's indeed possible to return the ALTER SYSTEM statement only after the notification has been broadcast to all nodes in the cluster, but the process of receiving and handling the notification remains asynchronous. So I'm afraid we are not able to completely eliminate the flakiness.
There was a problem hiding this comment.
handling the notification remains asynchronous
Is it possible we make it a synchronous process on meta by altering the parameter before repling to fe?
There was a problem hiding this comment.
It is synchronous on meta node, but the following check is performed on the frontend IIUC.
github-actions bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
Signed-off-by: xxchan <xxchan22f@gmail.com>
xxchan
added a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
temporary_kafka_batch.slt: In refactor(test): move some tests from source_legacy to source_inline #18894, we moved data generation from ci script (generate before tests) toslt(generate inline), which may cause the test fail.glue.slt: Alter license may not take effect immediately.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.