Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): fix some flaky e2e source tests #18989

Merged
merged 2 commits into from
Oct 18, 2024
Merged

fix(test): fix some flaky e2e source tests #18989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1344f0
fix(test): fix flaky temporary_kafka_batch.slt
xxchan Oct 18, 2024
743f9bb
fix license
xxchan Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions e2e_test/source_inline/kafka/avro/glue.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ EOF
statement ok
ALTER SYSTEM SET license_key TO '';

sleep 1s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also many other occurrences which may explode in the coming days, I suppose. 🤣

It's indeed possible to return the ALTER SYSTEM statement only after the notification has been broadcast to all nodes in the cluster, but the process of receiving and handling the notification remains asynchronous. So I'm afraid we are not able to completely eliminate the flakiness.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handling the notification remains asynchronous

Is it possible we make it a synchronous process on meta by altering the parameter before repling to fe?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is synchronous on meta node, but the following check is performed on the frontend IIUC.


statement error
create source t with (
connector = 'kafka',
Expand Down
6 changes: 6 additions & 0 deletions e2e_test/source_inline/kafka/temporary_kafka_batch.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,12 @@ t
t
t

# ensure now() is larger
sleep 1s
BugenZhao marked this conversation as resolved.
Show resolved Hide resolved

statement ok
flush;

query B
select _rw_kafka_timestamp < now() from s1
----
Expand Down
Loading