refactor(meta): extract code for connecting sql meta store #19603
+65
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugenZhao
force-pushed
the
bz/extract-sql-meta-store-connect
branch
from
f2d63d4 to
6d649e0
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
BugenZhao
force-pushed
the
bz/extract-sql-meta-store-connect
branch
from
6d649e0 to
fb9573e
Compare
BugenZhao
changed the base branch from
main
to
bz/bypass-cluster-limits-debug-build
4 tasks
Base automatically changed from
bz/bypass-cluster-limits-debug-build
to
main
November 29, 2024 05:39
yezizp2012
approved these changes
Dec 2, 2024
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
force-pushed
the
bz/extract-sql-meta-store-connect
branch
from
fb9573e to
926ae81
Compare
wenym1
pushed a commit
that referenced
this pull request
Dec 10, 2024
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Extract function for connecting to a SQL meta store from a backend configuration.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.