Skip to content

Commit

Permalink
Maint/CICD ~ fix coverage build failures by pinning to known-working …
Browse files Browse the repository at this point in the history
…nightly toolchain

## [why]

Code coverage must currently use some unstable features in nightly rust builds. The
nightly builds are, by definition, unstable and subject to frequent breaking changes.
To prevent CI build breakage, the toolchain is pinned to a specific known working set.

Note: (maint!) this will require periodic review until code coverage is more fully
implemented/integrated into Rust and moved into the stable channel.

- refs: <mozilla/grcov#427>, <newsboat/newsboat#916>
  • Loading branch information
rivy committed May 1, 2020
1 parent 796e619 commit 5e92417
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/CICD.yml
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,9 @@ jobs:
matrix:
# job: [ { os: ubuntu-latest }, { os: macos-latest }, { os: windows-latest } ]
job:
- { os: ubuntu-latest }
- { os: macos-latest }
- { os: windows-latest , toolchain: nightly-x86_64-pc-windows-gnu }
- { os: ubuntu-latest , toolchain: nightly-2020-04-29 }
- { os: macos-latest , toolchain: nightly-2020-04-29 }
- { os: windows-latest , toolchain: nightly-2020-04-29-x86_64-pc-windows-gnu }
steps:
- uses: actions/checkout@v1
- name: Initialize workflow variables
Expand Down

0 comments on commit 5e92417

Please sign in to comment.