Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GPUs in RaySampler #2323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support GPUs in RaySampler #2323

wants to merge 1 commit into from

Conversation

krzentner
Copy link
Contributor

This has been frequently requested. We've avoided adding support largely because it's difficult to test, and because for many environments sampling on cpu is more efficient anyways, but there are enough bug reports about this it's probably better to just support it.

@krzentner krzentner requested a review from a team as a code owner April 16, 2022 20:04
@krzentner krzentner requested review from ryanjulian and removed request for a team April 16, 2022 20:04
@mergify mergify bot requested review from a team, haydenshively and zequnyu and removed request for a team April 16, 2022 20:05
@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #2323 (3af5eeb) into master (c56513f) will decrease coverage by 0.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #2323      +/-   ##
==========================================
- Coverage   91.28%   91.26%   -0.02%     
==========================================
  Files         199      199              
  Lines       10981    10984       +3     
  Branches     1601     1603       +2     
==========================================
+ Hits        10024    10025       +1     
  Misses        695      695              
- Partials      262      264       +2     
Impacted Files Coverage Δ
src/garage/sampler/sampler.py 72.72% <ø> (+8.44%) ⬆️
src/garage/sampler/ray_sampler.py 99.21% <88.88%> (+1.69%) ⬆️
...rage/tf/optimizers/conjugate_gradient_optimizer.py 81.90% <0.00%> (-1.81%) ⬇️
src/garage/sampler/multiprocessing_sampler.py 90.12% <0.00%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c56513f...3af5eeb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant