Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[style] Fix pylint style #246

Merged
merged 3 commits into from
Apr 9, 2022
Merged

[style] Fix pylint style #246

merged 3 commits into from
Apr 9, 2022

Conversation

LuckyPigeon
Copy link
Collaborator

@LuckyPigeon LuckyPigeon commented Apr 8, 2022 •
edited
Loading

Description

Convert string to fstring format, to follow pylint rules.

upstream PR #247
fix #245

Solution

For example

raise ValueError("Failed to instantiate queue class '%s': %s", self.queue_cls, e)
# to
raise ValueError(f"Failed to instantiate queue class '{self.queue_cls}':  {e}")

@LuckyPigeon LuckyPigeon requested a review from Germey April 8, 2022 17:29
@LuckyPigeon LuckyPigeon changed the title [style] Convert string to fstring for src/ [style] Fix pylint style Apr 8, 2022
@LuckyPigeon LuckyPigeon merged commit cade7d3 into rmax:master Apr 9, 2022
LuckyPigeon added a commit to LuckyPigeon/scrapy-redis that referenced this pull request Jul 16, 2022
@LuckyPigeon
[style] Fix pylint style (rmax#246)
d6e7ac7 
* convert string to fstring for src/

* convert string to fstring for tests/

* remove u-string prefix
LuckyPigeon added a commit that referenced this pull request Jul 16, 2022
@LuckyPigeon @songhao8080
[test] Dev coverage (#235)
25f1c20 
* add coverage report

* fix push json (#239)

* Remove python 2.x support (#231)

* remove python 2.x support

* python3.6 has already deprecated

* update import scrapy_redis.utils (#232)

* [test] Dev flake8 style (#233)

* add flake8 rules

* add flake8 guide

* fix flake8 style suggestion

* [test] Dev bandit (#234)

* add bandit rules

* add bandit badge

* fix CWE-703

* [test] Dev tox (#237)

* update tox.ini

* fix push json (#239)

* Remove python 2.x support (#231)

* remove python 2.x support

* python3.6 has already deprecated

* update import scrapy_redis.utils (#232)

* [test] Dev flake8 style (#233)

* add flake8 rules

* add flake8 guide

* fix flake8 style suggestion

* [test] Dev bandit (#234)

* add bandit rules

* add bandit badge

* fix CWE-703

* replace pkg coverage with pytest-cov

* update CONTRIBUTING.rst to meet tox requirements

* update list indexes

Co-authored-by: songhao <5868037@qq.com>

* [docs] Update README.md (#236)

* landscape.io is already down

* update requires.io badge

update requires.io badge, local temporarily

* update badge source

* update requirements version

* fix gh copy function

* fix gh copy function

* fix gh copy function

* fix gh copy function

* move running example section to example/

* update links

* update indent

* Update contribution link

* [dev] Default value for json support data (#240)

* give default value to variable for push json

* add make_request_from_data comment

* update json supported data guide

* update json supported data guide

Co-authored-by: LuckyPigeon <lucky90322@gmail.com>

* Dev tox matrix (#244)

* support scarpy 1.x

* add python-scrapy tox matrix

* fix flake8 style

* add python-scrapy-redis matrix

* [test] Dev tox pylint (#247)

* add pylintrc

* add pylint for tox

* update pylint rules

* [style] Fix pylint style (#246)

* convert string to fstring for src/

* convert string to fstring for tests/

* remove u-string prefix

* Update setup (#227)

* remove redundant requirements files

* update setup.py and remove redundant functions

* update setup.py classifiers

* add requirements.txt for tox.ini to use

* update requirements.txt related settings

* update dependencies version

* update pkg version & introduce pytest-cov

* update python version

* Update .gitignore & LICENSE  (#225)

* update .gitignore & LICENSE

* remove contribution section and add alternative choice

* [docs] Remove docs $ prefix (#229)

* remove docs $ prefix

* align code indent

* Dev debug pytest (#230)

* add import hint for pytest

* update pytest usage

* update deprecated scrapy.utils.request usage

* Update .gitignore & LICENSE  (#225)

* update .gitignore & LICENSE

* remove contribution section and add alternative choice

* [docs] Remove docs $ prefix (#229)

* remove docs $ prefix

* align code indent

* add import hint for pytest

* add import hint for pytest

* add text color helper

* add json type check

add json formatted_data type check and warning message

* fix subset not equal assert

* update test & install guide

* fix push json (#239)

* Remove python 2.x support (#231)

* remove python 2.x support

* python3.6 has already deprecated

* update import scrapy_redis.utils (#232)

* [test] Dev flake8 style (#233)

* add flake8 rules

* add flake8 guide

* fix flake8 style suggestion

* [test] Dev bandit (#234)

* add bandit rules

* add bandit badge

* fix CWE-703

* [test] Dev tox (#237)

* update tox.ini

* fix push json (#239)

* Remove python 2.x support (#231)

* remove python 2.x support

* python3.6 has already deprecated

* update import scrapy_redis.utils (#232)

* [test] Dev flake8 style (#233)

* add flake8 rules

* add flake8 guide

* fix flake8 style suggestion

* [test] Dev bandit (#234)

* add bandit rules

* add bandit badge

* fix CWE-703

* replace pkg coverage with pytest-cov

* update CONTRIBUTING.rst to meet tox requirements

* update list indexes

Co-authored-by: songhao <5868037@qq.com>

* [docs] Update README.md (#236)

* landscape.io is already down

* update requires.io badge

update requires.io badge, local temporarily

* update badge source

* update requirements version

* fix gh copy function

* fix gh copy function

* fix gh copy function

* fix gh copy function

* move running example section to example/

* update links

* update indent

* Update contribution link

* [dev] Default value for json support data (#240)

* give default value to variable for push json

* add make_request_from_data comment

* update json supported data guide

* update json supported data guide

Co-authored-by: LuckyPigeon <lucky90322@gmail.com>

* update flake8

Co-authored-by: songhao <5868037@qq.com>

* convert the data from redis from bytes to str (#249)

* ignore setup.py coverage

Co-authored-by: songhao <5868037@qq.com>
@LuckyPigeon LuckyPigeon mentioned this pull request Jul 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Germey Germey Germey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[style] Fix pylint style
2 participants
@LuckyPigeon @Germey