[test] Dev tox pylint #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Germey
approved these changes
Apr 9, 2022
LuckyPigeon
added a commit
to LuckyPigeon/scrapy-redis
that referenced
this pull request
Jul 16, 2022
* add pylintrc * add pylint for tox * update pylint rules
LuckyPigeon
added a commit
that referenced
this pull request
Jul 16, 2022
* add coverage report * fix push json (#239) * Remove python 2.x support (#231) * remove python 2.x support * python3.6 has already deprecated * update import scrapy_redis.utils (#232) * [test] Dev flake8 style (#233) * add flake8 rules * add flake8 guide * fix flake8 style suggestion * [test] Dev bandit (#234) * add bandit rules * add bandit badge * fix CWE-703 * [test] Dev tox (#237) * update tox.ini * fix push json (#239) * Remove python 2.x support (#231) * remove python 2.x support * python3.6 has already deprecated * update import scrapy_redis.utils (#232) * [test] Dev flake8 style (#233) * add flake8 rules * add flake8 guide * fix flake8 style suggestion * [test] Dev bandit (#234) * add bandit rules * add bandit badge * fix CWE-703 * replace pkg coverage with pytest-cov * update CONTRIBUTING.rst to meet tox requirements * update list indexes Co-authored-by: songhao <5868037@qq.com> * [docs] Update README.md (#236) * landscape.io is already down * update requires.io badge update requires.io badge, local temporarily * update badge source * update requirements version * fix gh copy function * fix gh copy function * fix gh copy function * fix gh copy function * move running example section to example/ * update links * update indent * Update contribution link * [dev] Default value for json support data (#240) * give default value to variable for push json * add make_request_from_data comment * update json supported data guide * update json supported data guide Co-authored-by: LuckyPigeon <lucky90322@gmail.com> * Dev tox matrix (#244) * support scarpy 1.x * add python-scrapy tox matrix * fix flake8 style * add python-scrapy-redis matrix * [test] Dev tox pylint (#247) * add pylintrc * add pylint for tox * update pylint rules * [style] Fix pylint style (#246) * convert string to fstring for src/ * convert string to fstring for tests/ * remove u-string prefix * Update setup (#227) * remove redundant requirements files * update setup.py and remove redundant functions * update setup.py classifiers * add requirements.txt for tox.ini to use * update requirements.txt related settings * update dependencies version * update pkg version & introduce pytest-cov * update python version * Update .gitignore & LICENSE (#225) * update .gitignore & LICENSE * remove contribution section and add alternative choice * [docs] Remove docs $ prefix (#229) * remove docs $ prefix * align code indent * Dev debug pytest (#230) * add import hint for pytest * update pytest usage * update deprecated scrapy.utils.request usage * Update .gitignore & LICENSE (#225) * update .gitignore & LICENSE * remove contribution section and add alternative choice * [docs] Remove docs $ prefix (#229) * remove docs $ prefix * align code indent * add import hint for pytest * add import hint for pytest * add text color helper * add json type check add json formatted_data type check and warning message * fix subset not equal assert * update test & install guide * fix push json (#239) * Remove python 2.x support (#231) * remove python 2.x support * python3.6 has already deprecated * update import scrapy_redis.utils (#232) * [test] Dev flake8 style (#233) * add flake8 rules * add flake8 guide * fix flake8 style suggestion * [test] Dev bandit (#234) * add bandit rules * add bandit badge * fix CWE-703 * [test] Dev tox (#237) * update tox.ini * fix push json (#239) * Remove python 2.x support (#231) * remove python 2.x support * python3.6 has already deprecated * update import scrapy_redis.utils (#232) * [test] Dev flake8 style (#233) * add flake8 rules * add flake8 guide * fix flake8 style suggestion * [test] Dev bandit (#234) * add bandit rules * add bandit badge * fix CWE-703 * replace pkg coverage with pytest-cov * update CONTRIBUTING.rst to meet tox requirements * update list indexes Co-authored-by: songhao <5868037@qq.com> * [docs] Update README.md (#236) * landscape.io is already down * update requires.io badge update requires.io badge, local temporarily * update badge source * update requirements version * fix gh copy function * fix gh copy function * fix gh copy function * fix gh copy function * move running example section to example/ * update links * update indent * Update contribution link * [dev] Default value for json support data (#240) * give default value to variable for push json * add make_request_from_data comment * update json supported data guide * update json supported data guide Co-authored-by: LuckyPigeon <lucky90322@gmail.com> * update flake8 Co-authored-by: songhao <5868037@qq.com> * convert the data from redis from bytes to str (#249) * ignore setup.py coverage Co-authored-by: songhao <5868037@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pylintis a general style flag, aside fromflake8, we should add it. And also,toxwithpylintwill also be added.Solution
Add
pylintrcfor basic settings and rules, and addtoxwithpylintfor tests after every change.Current
pylintfortoxwill failed since there's planety lint issues to fix, I'll open another issue for these fix.