Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add smtp client to AppContext #391

Merged
merged 2 commits into from
Oct 8, 2024
Merged

feat: Add smtp client to AppContext #391

merged 2 commits into from
Oct 8, 2024

Conversation

spencewenski
Copy link
Member

Use the smtp connection details from the AppConfig::email::smtp config to build an smtp client using the lettre crate.

Use the smtp connection details from the `AppConfig::email::smtp` config
to build an smtp client using the `lettre` crate.
@spencewenski spencewenski mentioned this pull request Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 42.81%. Comparing base (b7eeac3) to head (9c9d9c5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/config/email/smtp.rs 0.00% 12 Missing ⚠️
src/app/context.rs 0.00% 9 Missing ⚠️
src/error/email.rs 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
src/error/mod.rs 0.00% <ø> (ø)
src/error/email.rs 0.00% <0.00%> (ø)
src/app/context.rs 21.12% <0.00%> (-1.27%) ⬇️
src/config/email/smtp.rs 17.24% <0.00%> (-12.18%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7eeac3...9c9d9c5. Read the comment docs.

@spencewenski spencewenski merged commit 0dd1b6d into main Oct 8, 2024
15 of 16 checks passed
@spencewenski spencewenski deleted the smtp-client branch October 8, 2024 22:26
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
spencewenski added a commit that referenced this pull request Oct 9, 2024
## 🤖 New release
* `roadster`: 0.6.4 -> 0.6.5 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.6.5](roadster-v0.6.4...roadster-v0.6.5)
- 2024-10-09

### Added

- Add `SmtpHealthCheck`
([#396](#396))
- Allow specifying the smtp port via config
([#395](#395))
- Add smtp client to `AppContext`
([#391](#391))
- Add support to config for email via SMTP (`email-smtp` feature)
([#388](#388))

### Fixed

- Fix config value used for timeout of health check in api and cli
([#397](#397))

### Other

- Add example of sending email using lettre smtp client
([#394](#394))
- Add doc comment explaining how NormalizePathLayer works
([#393](#393))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Spencer Ferris <3319370+spencewenski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant