Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gazebo_yarp_maissensor: Expose data via yarp::dev::IEncoderArrays and add support for disableImplicitNetworkWrapper, yarpDeviceName and sensorName parameters #688

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Sep 18, 2024

Fix part of robotology/icub-models#234 . The only missing part to understand is which name to return in the getEncoderArrayName, waiting for feedback in robotology/icub-models#234 (comment) to proceed.

Inspired by robotology/icub-main#905 .

fyi @pattacini @martinaxgloria

@traversaro traversaro changed the title maissensor: Expose data via yarp::dev::IEncoderArrays gazebo_yarp_maissensor: Expose data via yarp::dev::IEncoderArrays Sep 18, 2024
@traversaro
Copy link
Member Author

Some failures are unrelated to the PR (#687 and #686).

@traversaro traversaro changed the title gazebo_yarp_maissensor: Expose data via yarp::dev::IEncoderArrays gazebo_yarp_maissensor: Expose data via yarp::dev::IEncoderArrays and add support for disableImplicitNetworkWrapper, yarpDeviceName and sensorName parameters Sep 18, 2024
@traversaro
Copy link
Member Author

The only missing part to understand is which name to return in the getEncoderArrayName, waiting for feedback in robotology/icub-models#234 (comment) to proceed.

This was fixed, now the value returned by the getEncoderArrayName method is specified by sensorName argument as in this specific case we do not have any sdf sensor corresponding to the main/array encoder, so we need to specify the sensor name in some other way.

@traversaro traversaro merged commit 50f2386 into master Sep 19, 2024
4 of 10 checks passed
@traversaro traversaro deleted the fixicubmodels234 branch September 19, 2024 07:26
@traversaro
Copy link
Member Author

If you need to migrate existing instances of gazebo_yarp_maissensor to use MAS interfaces and gazebo_yarp_robotinterface, use robotology/icub-models#240 as a reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant