Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set joints to NOT_CONFIGURED at YRI closure using MotionController Deactivate() API #413

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Sep 7, 2023

In order to solve problems of joints going in hw limit fault at yarprobotinterface restart now joints are set to NOT_CONFIGURED control mode at YRI closure, therefore at restart they can re-calibrate effectively as shown ad explained in this issue

@MSECode MSECode requested a review from valegagge September 7, 2023 13:35
@MSECode MSECode self-assigned this Sep 7, 2023
@MSECode
Copy link
Contributor Author

MSECode commented Sep 7, 2023

The merging branch has already be rebase on top of https://github.com/MSECode/icub-firmware/tree/feature/batteryStatus

@MSECode MSECode marked this pull request as draft September 7, 2023 13:41
Currently joints are set in NOT CONFIGURED when YRI is stopped using MController_deinit() api
Remove unnecessary comments
@MSECode MSECode force-pushed the feature/jointToNotConfig branch from 3ee19f6 to d2a80bc Compare September 8, 2023 15:31
@MSECode MSECode marked this pull request as ready for review September 8, 2023 15:32
@MSECode MSECode marked this pull request as draft September 8, 2023 15:34
@MSECode MSECode marked this pull request as ready for review September 8, 2023 15:51
@MSECode MSECode requested a review from Nicogene September 8, 2023 15:52
Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants