Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit period parameter(0.01 s) for the controlboard_nws_yarp #379

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Sep 1, 2022

This PR addresses #378

Please review code

@Nicogene Nicogene self-assigned this Sep 1, 2022
@traversaro
Copy link
Member

fyi @GiulioRomualdi @S-Dafarra

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nicogene

I would rule out the robots R1 from this PR. We could address them separately if we decide to do so.

Also, could you check if we can update files in iCubTemplates/iCubTemplateV6_0?

@pattacini
Copy link
Member

cc @xEnVrE for iCubGenova01

@Nicogene
Copy link
Member Author

Nicogene commented Sep 1, 2022

@pattacini I removed R1 from the PR, and I checked iCubTemplates/iCubTemplateV6_0 and the only wrappers in the template are the ones of FT and inertials

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks heaps @Nicogene

Before merging, I think it's worth giving it a try on iCubGenova01 and iCubGenova09.

@xEnVrE, @S-Dafarra, @GiulioRomualdi are you willing to do a quick test?

@S-Dafarra
Copy link
Contributor

@xEnVrE, @S-Dafarra, @GiulioRomualdi are you willing to do a quick test?

On it

@xEnVrE
Copy link
Contributor

xEnVrE commented Sep 1, 2022

@pattacini tested on iCubGenova01 (excluding legs and the left arm that is not available at the moment).

The difference in timestamps from a yarpdatadumper log (configured to collect transmission times) reads, e.g., 0.010070085525512695. Seems alright.

@pattacini
Copy link
Member

@pattacini tested on iCubGenova01 (excluding legs and the left arm that is not available at the moment).

The difference in timestamps from a yarpdatadumper log (configured to collect transmission times) reads, e.g., 0.010070085525512695. Seems alright.

Super! Thanks heaps.

@S-Dafarra
Copy link
Contributor

I tested the walking on iCubGenova09 and it seems to be ok!

@pattacini
Copy link
Member

I tested the walking on iCubGenova09 and it seems to be ok!

Thanks!
Merging...

@pattacini pattacini merged commit 5a8d3dd into master Sep 1, 2022
@pattacini pattacini deleted the fix/controlboardNwsPeriod branch September 1, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unintended change of frequency of iCub's controlBoard_nws_yarp instances from 100 Hz to 50 Hz
5 participants