-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit period parameter(0.01 s) for the controlboard_nws_yarp #379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Nicogene
I would rule out the robots R1 from this PR. We could address them separately if we decide to do so.
Also, could you check if we can update files in iCubTemplates/iCubTemplateV6_0
?
cc @xEnVrE for iCubGenova01 |
39d1cb8
to
e56565a
Compare
@pattacini I removed R1 from the PR, and I checked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks heaps @Nicogene
Before merging, I think it's worth giving it a try on iCubGenova01 and iCubGenova09.
@xEnVrE, @S-Dafarra, @GiulioRomualdi are you willing to do a quick test?
On it |
@pattacini tested on iCubGenova01 (excluding legs and the left arm that is not available at the moment). The difference in timestamps from a |
Super! Thanks heaps. |
I tested the walking on iCubGenova09 and it seems to be ok! |
Thanks! |
This PR addresses #378
Please review code