Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update php.md" #1695

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Revert "Update php.md" #1695

merged 1 commit into from
Jan 26, 2024

Conversation

sspencerwire
Copy link
Contributor

Reverts #1693
Not correct yet...

@sspencerwire sspencerwire merged commit 2ca2ff5 into main Jan 26, 2024
2 checks passed
Copy link

Test results for c6bc03c:

Number of broken URLs: 2

URL,RESULT,FILENAME
 https://linoxide.com/install-cockpit-on-almalinux-or-rocky-linux/,failed,guides/security/firewalld-beginners.md
 https://www.linode.com/docs/guides/beginners-guide-to-lxd-reverse-proxy,failed,guides/containers/lxd_web_servers.md

@sspencerwire
Copy link
Contributor Author

@j0eybrinkman Unfortunately, after merging there were a bunch of problems. I needed to revert the PR back to the original. If you still have the your PR in your branch, here's what I'd suggest: Go back and read that formatting document again very carefully. Everything needs to be separated by four (4) spaces as soon as you use the tabbed format (===9.x) All of the 9.x and the 8.x content should then be kept together, rather than spread out throughout the document. The spacing issues caused the rest of the document to render incorrectly as well. It's a little tricky to do some of this, I'll admit. I (and a few other editors and contributors) use a local copy of the mkdocs web engine so that we can easily "see" how are changes will reflect in the browser, and this helps to keep us from making mistakes. If I had more time today, I'd have gone through your changes and edited them so that they wold work in the document, but I just didn't have the time. Are you on our Mattermost discussion? (chat.rockylinux.org)? If so, I can talk you through some of this. Let me know. Again, I do appreciate your effort!

@j0eybrinkman
Copy link
Contributor

@sspencerwire Thank you for letting me know! I will take another go at this later today. And no I am not in the matter most discussion but will join it later today. Again, thank you for the help!

@sspencerwire
Copy link
Contributor Author

@j0eybrinkman Just checking in with you. I didn't want to discourage your contribution to the project. Again, if you join the chat.rockylinux.org platform, I can help you a lot more with what you are attempting to do. No pressure! :-)

@j0eybrinkman
Copy link
Contributor

Hi @sspencerwire, you definitely have not discouraged me, quite the opposite. I appreciate your help and detailed responses. I joined the mattermost discussion this morning and going to follow your advice and take another crack at this!

@sspencerwire sspencerwire deleted the revert-1693-patch-1 branch April 19, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants