Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show failed additions and removals in visualizer #844

Merged

Conversation

boatbomber
Copy link
Member

Closes #842. Includes a minor refactor to use guard clauses and more comments since there's a lot of loops and conditions here and I find this more maintainable.

image

@boatbomber boatbomber self-assigned this Jan 31, 2024
@boatbomber boatbomber requested a review from Dekkonot January 31, 2024 22:38
@boatbomber boatbomber added type: bug Something happens that shouldn't happen scope: plugin Relevant to the Roblox Studio plugin labels Jan 31, 2024
@Dekkonot Dekkonot added the skip changelog PRs that may skip the changelog enforcement check label Jan 31, 2024
@Dekkonot Dekkonot merged commit 106a012 into rojo-rbx:master Jan 31, 2024
6 of 10 checks passed
@boatbomber boatbomber deleted the show-failed-additions-and-removals branch January 31, 2024 23:41
kennethloeffler pushed a commit to kennethloeffler/rojo that referenced this pull request Feb 1, 2024
Dekkonot pushed a commit that referenced this pull request Feb 1, 2024
Co-authored-by: boatbomber <zack@boatbomber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: plugin Relevant to the Roblox Studio plugin skip changelog PRs that may skip the changelog enforcement check type: bug Something happens that shouldn't happen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch visualizer doesn't display failed instance additions
2 participants