Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show failed additions and removals in visualizer #844

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Show failed additions and removals in visualizer #844

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18317d9
Update node metadata using all of the patch, not just updated
boatbomber Jan 31, 2024
bc87f73
Add comment
boatbomber Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 58 additions & 14 deletions plugin/src/PatchTree.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,22 +426,66 @@ function PatchTree.updateMetadata(tree, patch, instanceMap, unappliedPatch)
-- Update isWarning metadata
for _, failedChange in unappliedPatch.updated do
local node = tree:getNode(failedChange.id)
if node then
node.isWarning = true
Log.trace("Marked node as warning: {} {}", node.id, node.name)

if node.changeList then
for _, change in node.changeList do
if failedChange.changedProperties[change[1]] then
Log.trace(" Marked property as warning: {}", change[1])
if change[4] == nil then
change[4] = {}
end
change[4].isWarning = true
end
end
if not node then
continue
end

node.isWarning = true
Log.trace("Marked node as warning: {} {}", node.id, node.name)

if not node.changeList then
continue
end
for _, change in node.changeList do
if not failedChange.changedProperties[change[1]] then
-- This change didn't fail
continue
end
if change[4] == nil then
change[4] = { isWarning = true }
else
change[4].isWarning = true
end
Log.trace(" Marked property as warning: {}.{}", node.name, change[1])
end
end
for failedAdditionId in unappliedPatch.added do
local node = tree:getNode(failedAdditionId)
if not node then
continue
end

node.isWarning = true
Log.trace("Marked node as warning: {} {}", node.id, node.name)

if not node.changeList then
continue
end
for _, change in node.changeList do
-- Failed addition means that all properties failed to be added
if change[4] == nil then
change[4] = { isWarning = true }
else
change[4].isWarning = true
end
Log.trace(" Marked property as warning: {}.{}", node.name, change[1])
end
end
for _, failedRemovalIdOrInstance in unappliedPatch.removed do
local failedRemovalId = if Types.RbxId(failedRemovalIdOrInstance)
then failedRemovalIdOrInstance
else instanceMap.fromInstances[failedRemovalIdOrInstance]
if not failedRemovalId then
continue
end

local node = tree:getNode(failedRemovalId)
if not node then
continue
end

node.isWarning = true
Log.trace("Marked node as warning: {} {}", node.id, node.name)
end

-- Update if instances exist
Expand Down
Loading