Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspend http transactions for 30 seconds in case of failure #71

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Conversation

matux
Copy link
Collaborator

@matux matux commented Aug 10, 2022

Description of the change

We were doing this through the ConnectivityManager, which was removed yesterday.

This adds the suspension back with the main goal of keeping this behavior for the next release.

A proper solution will come when #70 is addressed.

A proper solution will see the payload flow abstracted frp-style into a stream of payloads over time and just model the flow of time declaratively and without managing state instead of this horribleness.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux requested a review from akornich August 10, 2022 16:23
@matux matux self-assigned this Aug 10, 2022
@matux matux requested a review from akornich August 10, 2022 17:19
Copy link
Contributor

@akornich akornich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matux matux merged commit 20d1a55 into main Aug 10, 2022
@matux matux deleted the defer branch August 10, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants