Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(provider): allow config not to be required when instance used #10

Merged
merged 1 commit into from
Jan 25, 2022
Merged

fix(provider): allow config not to be required when instance used #10

merged 1 commit into from
Jan 25, 2022

Conversation

eudaimos
Copy link
Contributor

Description of the change

API documentation states that either a config prop with a Rollbar configuration as a hash can be passed to the Provider or an instance prop which is a constructed instance of Rollbar. When the instance prop is being used, the Provider is complaining that the required config prop is not being set per the prop types definitions.

This PR fixes this issue.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Fix #8

@eudaimos eudaimos requested a review from waltjones June 30, 2021 05:04
waltjones
waltjones approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good.

@waltjones waltjones merged commit 6ea0b28 into main Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltjones waltjones waltjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provider config should not be required if instance provided
2 participants
@eudaimos @waltjones