Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(provider): allow config not to be required when instance used #10

Merged
merged 1 commit into from
Jan 25, 2022
Merged

fix(provider): allow config not to be required when instance used #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/provider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,26 @@ export function getRollbarConstructorFromContext(context) {
export class Provider extends Component {
static propTypes = {
Rollbar: PropTypes.func,
config: PropTypes.oneOfType([PropTypes.object, PropTypes.func]).isRequired,
instance: PropTypes.instanceOf(Rollbar),
config: (props, propName, componentName) => {
if (!props.config && !props.instance) {
return new Error(`One of the required props 'config' or 'instance' must be set for ${componentName}.`)
}
if (props.config) {
const configType = typeof props.config;
if (configType === 'function' || configType === 'object' && !Array.isArray(configType)) {
return;
}
return new Error(`${propName} must be either an Object or a Function`);
}
},
instance: (props, propName, componentName) => {
if (!props.config && !props.instance) {
return new Error(`One of the required props 'config' or 'instance' must be set for ${componentName}.`)
}
if (props.instance && !(props.instance instanceof Rollbar)) {
return new Error(`${propName} must be an instance of Rollbar`);
}
}
}

constructor(props) {
Expand Down